search

sumimakito / Awesome-qr.js

An awesome QR code generator written in JavaScript.
https://www.bitcat.cc/webapp/awesome-qr/index.html
Apache License 2.0
1.67k stars 251 forks source link

.npmignore file #69

Open skibz opened 3 years ago

skibz commented 3 years ago

Is there a valid reason why this package includes gifs and pngs when installed from NPM? They weigh in at 16 megabytes, and I doubt downstream codebases are likely to use them.

ant$ du -h node_modules/awesome-qr
4.0K    node_modules/awesome-qr/test
 48K    node_modules/awesome-qr/dist
 16M    node_modules/awesome-qr/art
 76K    node_modules/awesome-qr/lib/gif.js
 24K    node_modules/awesome-qr/lib/gifuct-js
192K    node_modules/awesome-qr/lib
 48K    node_modules/awesome-qr/src/gif.js
 12K    node_modules/awesome-qr/src/gifuct-js
128K    node_modules/awesome-qr/src
 16M    node_modules/awesome-qr

Please could we add a .npmignore file that prevents these images (and any other source code that isn't required to use the library) from being published?

I'd be happy to submit a patch for this, if you're open to the idea.