hw06 ready for grading

[suminwei2772]

README.md for hw06

hw06_data_wrangling.md

[margotgunning]

Hey @suminwei2772 ,

You have a very clean HW repo that is easy to navigate with READMEs. I liked how you added a little description of the hw file in the README behind the hyperlink.

First, I liked how you have a description under your task header; it was very helpful in orientating my thinking before diving into your analysis. Also, great job hashing out comments in your script as it made it very easy to follow! You were successful in creating your quadratic function, and it was nice to see how you modified it to scale-up. The only thing I would have liked to see was perhaps an interpretation of some of the results ie) which country had the best fit ect.

Again, you did a great job of hashing out your code in task 6, and tackling the problem in a series of smaller steps; I really liked how you gave an outline of your steps before launching into them. The plots you made were good, but I would have liked to see some interpretation.

In your progress, I liked how you had the warning for the quadratic formula syntax. I also had trouble using map(), and it was good to see that you sourced the tutorial.

Overall, well done!

M

[yuanjisun]

Hello @suminwei2772,

I have to say you really did a very good job. Here are my comments.

Report process

1. I am glad that you mentioned problems you ran into. I also had similar problems as you.
2. I learned a lot from the link provided, which helps me understand how to use map().

Task 2: Write functions

1. I appreciate that you used a quadratic model instead of a linear one.
2. It is really helpful to see how you develop your function step by step, from working on one country to fitting all countries by generating a table of coefficients.
3. The description of your work is very clear, helping me understand what you did.
4. Your code works well and reached the goal that you wanted to meet.

Suggestion

1. It would be better to sort the result based on some certain criteria, such as coef1 from highest to lowest. This would make it easier to see which country is fitted very well and which country is not suitable for this model.

Task 6: Work on a nested dataframe

1. You successfully nested the dataframe.
2. I really enjoy seeing how you solve the problem step by step. I learned a lot from your work, especially the last part.
3. It is great to see you did some analysis on the model coefficient, which makes your work more meaningful.
4. The figures are really nice, easy to read and easy to understand. They contain a lot of information which is directly related with your code.

Suggestion

1. It would be better to view your nested dataframe using jasonedit, which is interactive and easy to see the results.

Other suggestions

1. It would be better to have RMD file in your repo.

Overall, I really like your homework and you really did a very good job.

Yuanji

[ksedivyhaley]

At least two topics: Yes (functions, nested data frame) Functions: OK Nested data frame: Needs more Reflection: Yes

Comments:

• The function could be improved with error handling – check to make sure the function has received a data frame with the appropriate columns.
• It's fine to use Jenny's tutorial as a starting point, but to get full credit for this task you would need to do something a bit more – at minimum using a quadratic instead of a linear model, or do some novel exploration of the results.

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.