Closed prestwich closed 2 years ago
for the lockfile, I believe the "official" recommendation is to avoid committing it for libraries as dependency compilation will ignore the lockfile anyway
I don't have a particular attachment to that recommendation tho
this seems to be completely unused, hence the unused warnings, was apparently deprecated in https://github.com/summa-tx/bitcoins-rs/pull/90, so we should be able to remove that entirely?
yes I believe those can be deleted
for the lockfile, I believe the "official" recommendation is to avoid committing it for libraries as dependency compilation will ignore the lockfile anyway
I don't have a particular attachment to that recommendation tho
wasn't aware that this faq exists, makes total sense. let's rm lock file and --locked flags
made a couple of changes
Cargo.lock
so we can run --locked in CIthis seems to be completely unused, hence the unused warnings, was apparently deprecated in #90, so we should be able to remove that entirely?
https://github.com/summa-tx/bitcoins-rs/blob/8a855b78e472f4476b8cffc455319cb58baffb54/ledger/src/transports/hid.rs#L334