search

summa-tx / riemann-keys

cryptocurrency hd keys for humans🎈🎈
Other
8 stars 1 forks source link

objects #1

Closed prestwich closed 5 years ago

prestwich commented 6 years ago

Commute thought

I'd prefer if nodes were the only real objects, and everything else defaulted to standard python types (bytes, strings, tuples)

arshbot commented 6 years ago

Interesting, I was wondering the same thing as well. What we have now contains every major component as an object.

I'm not against a single class. Would reduce complexity as well

prestwich commented 6 years ago

I made a list of current objects. Most of these I don't see a point to

HDKey
PrivateKeyBase
PrivateKey
HDPrivate Key
PublicKeyBase
PublicKey
HDPublicKey
Signature
arshbot commented 6 years ago

I agree - the only one that should stay is HDKey. The intent of the contents of #5 is to be cannibalized and sifted through for anything useful