summa-tx / riemann-keys

cryptocurrency hd keys for humans🎈🎈
Other
8 stars 1 forks source link

Return an HDKey from mnemonic #10

Closed arshbot closed 5 years ago

arshbot commented 6 years ago

Must be able to generate an entirely seperate object from a mnemonic.

from_mnemonic

rrybarczyk commented 6 years ago

do you want a method that generates entropy from os.urandom and uses that to generate a new mnemonic return a new HDKey object? user can input whether they want a 12, 15, 18, 21, or 24 word mnemonic. can default to 24.

so they have the option of providing their own mnemonic with the from_mnemonic method or having everything generated for them from scratch, called from_generated_mnemonic or something.

drmoog commented 6 years ago

I think that's a good option. The kind of smooth user exp. we want

On Wed, Aug 29, 2018 at 10:37 AM RJ Rybarczyk notifications@github.com wrote:

do you want a method that generates entropy from os.urandom and uses that to generate a new mnemonic return a new HDKey object? user can input whether they want a 12, 15, 18, 21, or 24 word mnemonic. can default to 24.

so they have the option of providing their own mnemonic with the from_mnemonic method or having everything generated for them from scratch, called from_generated_mnemonic or something.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/summa-tx/riemann-keys/issues/10#issuecomment-417040164, or mute the thread https://github.com/notifications/unsubscribe-auth/AhMYYdHOcq44e_D5ix98lbZQNx0Rou8Hks5uVtFPgaJpZM4WM52a .