summerlabs / punic

Punic is a remote cache CLI built for Carthage and Apple .xcframework
https://andrewaquino118.medium.com/remote-caching-apples-xcframework-2fcf574392c5
28 stars 2 forks source link

Adds support to select the default aws Region #8

Closed miscampbell closed 3 years ago

miscampbell commented 3 years ago

This PR addresses Issue 7 (https://github.com/summerlabs/punic/issues/7)

Further Documentation https://rusoto.github.io/rusoto/rusoto_core/region/enum.Region.html

Changes Made Updated s3.rs to use the Region::default() instead of the hardcoded uswest1.

Improvements This will provide greater flexibility for users and also ensure that the region can be tweaked externally via the aws config file. This addresses the issue we were seeing where files were not being uploaded to AWS S3.

Please can we merge this and release a new version 0.8?

Thank you to all involved in this project it is going to be extremely useful for our team :)

jcheungshred commented 3 years ago

Sweet thank you!!