summernote / summernote

Super simple WYSIWYG editor
https://summernote.org
MIT License
11.4k stars 2.24k forks source link

fixes jQuery lower/uppercase issue #3537 and reverts commit b5da43e824ed3aeb7f3d36fcd1038ca28774db48 #4596

Closed HoffmannTom closed 4 months ago

HoffmannTom commented 4 months ago

What does this PR do?

jQuery is used in lower- and uppercase, depending on how it is packaged and used. Including jQuery on a website registers the object "jQuery" and the Q must be uppercase.

Where should the reviewer start?

config/webpack.production.js

How should this be manually tested?

Build the project and create a summernote editor within a HTML page.

Any background context you want to provide?

fixes issue #3537

What are the relevant tickets?

fixes #3537

Screenshot (if for frontend)

Checklist

DennisSuitters commented 4 months ago

Confirmed working here, YAY, thank you so much for finally providing a fix for this. I hope you know how much people are going to appreciate your efforts.

HoffmannTom commented 4 months ago

@DiemenDesign Maybe you can also check #4539 and #4462 I think they are related to the same issue. Maybe they can be closed too.

wonsuc commented 3 months ago

Thank you so much.