XSS Vulnerability Report: Discovering XSS Vulnerability through Data Schema Manipulation

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[X] I'm sure this is an issue with Summernote, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I've searched through the current issues to make sure this hasn't been reported yet.
[X] My issue is pertinent to this repository of Summernote (jQuery), or I was unable to have my issue resolved from the relevant version I'm using, such as Angular, dJango, Rails or React. Please try your issue at the relevent repository first.
[X] I understand that issues without interaction for more than 14 days (2 weeks), may be closed at our discretion. We do this, as sometimes issues are abandoned. We may at our discretion, add issues to the relevant project to be looked at, or for maintainers to work through as time permits. This is to help keep issues relevant to the current version of Summernote, and to reduce clutter.
[X] I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce

Step1. Click on the "Insert Image" button within the Summernote functionality.

Step2. Select an arbitrary image and insert it.

Step3. Click on the "Code View" button.

Step4. Attempt an XSS attack by manipulating the code of the inserted image. </code></p> <p><img referrerpolicy="no-referrer" src="https://github.com/summernote/summernote/assets/100998394/ba57bc97-186e-45ec-a74a-4864756134e7" alt="5" /></p> <p><img referrerpolicy="no-referrer" src="https://github.com/summernote/summernote/assets/100998394/93170e42-2587-4201-b25c-92edb53815e4" alt="6" /></p> <p><strong>Step5. Confirm that the Base64-encoded XSS attack code is indeed stored and operational, demonstrating its functionality.</strong></p> <p><img referrerpolicy="no-referrer" src="https://github.com/summernote/summernote/assets/100998394/e9e8cd85-780a-4aa3-b6aa-293f9fc6b436" alt="7" /></p> <p><img referrerpolicy="no-referrer" src="https://github.com/summernote/summernote/assets/100998394/a1139079-9442-495e-92f5-1906d91a6323" alt="8" /></p> <h3>Expected behavior</h3> <p><strong>[Expected behavior]</strong></p> <p>I expected that upon following the outlined steps, the Summernote functionality would insert the selected image as intended. Additionally, I anticipated that the Code View feature would allow for the manipulation of the inserted image's code. However, I did not expect the system to accept and execute the Base64-encoded XSS attack code, as this would indicate a vulnerability in the application's security measures.</p> <h3>Current behavior</h3> <p><strong>[Current behavior]</strong></p> <p>After following the specified steps, the Summernote functionality successfully inserts the selected image into the editor. When switching to Code View and attempting to manipulate the code of the inserted image with Base64-encoded XSS attack code, the application does not prevent the insertion or execution of the malicious code. This behavior was observed in version 0.8.18 during my demonstration. Furthermore, similar findings were confirmed in a different environment running version 0.8.20, indicating that the vulnerability persists across multiple versions. This poses a serious security risk as it allows for potential exploitation of cross-site scripting vulnerabilities.</p> <p><a rel="noreferrer nofollow" target="_blank" href="https://github.com/summernote/summernote/assets/100998394/52f1e94b-d9e1-4f10-91cc-05e015b77a21">https://github.com/summernote/summernote/assets/100998394/52f1e94b-d9e1-4f10-91cc-05e015b77a21</a></p> <h3>Minimal example reproducing the issue</h3> <iframe src="data:text/html;base64,PGltZyBzcmM9MSBvbmVycm9yPXdpbmRvdy5vcGVuKCdodHRwczovL3d3dy5nb29nbGUuY29tJyk+"> ### Environment - Summernote version: 0.8.20 - Browser (with version): Chrome 124.0.6367.119 - OS/Platform (with version): Windows 11 laptop </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/EunhoKim98"><img src="https://avatars.githubusercontent.com/u/100998394?v=4" />EunhoKim98</a> commented <strong> 3 weeks ago</strong> </div> <div class="markdown-body"> <p>The hacking demonstration is version 0.8.18, but I also succeeded in that attack in version 0.8.20.</p> <p>[filtering code] function filterHtmlSchema(data) { return data.filter(item => { const schema = item.schema; return !schema || !schema.hasOwnProperty("text/html"); }); }</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HoffmannTom"><img src="https://avatars.githubusercontent.com/u/27145868?v=4" />HoffmannTom</a> commented <strong> 3 weeks ago</strong> </div> <div class="markdown-body"> <p>I think the html code should be cleaned and filtered on the server side. I use jsoup in java with a whitelist for this purpose. For PHP there are similar extensions and libraries.</p> <p>For your example, you could also use F12 and inject an alert without any summernote. The attack should not be reflected but of course you can inject anything in your browser by yourself.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

summernote / summernote

XSS Vulnerability Report: Discovering XSS Vulnerability through Data Schema Manipulation #4638

Checklist

Steps to reproduce