search

summerofcode / gsoc-orgs

Google Summer of Code organisation listing
https://soc-orgs.netlify.com/
3 stars 3 forks source link

Adding basic visualization for organization list using P5.js #16

Closed BlinfoldKing closed 6 years ago

jayvdb commented 6 years ago

@gitmate-bot rebase

jayvdb commented 6 years ago

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

jayvdb commented 6 years ago

Automated rebase with GitMate.io was successful! :tada:

jayvdb commented 6 years ago

yay, preview is working https://deploy-preview-16--soc-orgs.netlify.com/list.html

jayvdb commented 6 years ago

On the view of a single category, with lots of orgs, what is determining the layout. The placement of the org nodes doesnt have an obvious purpose. If there is a good reason for the layout, maybe add a note explaining it to the user.

BlinfoldKing commented 6 years ago

the orgs is currently spawn at random position, i'm currently still searching for a way to represent the data.

jayvdb commented 6 years ago

Also need to replace jquery & p5 with CDN versions.

BlinfoldKing commented 6 years ago

i've already replace it with the cdn version

jayvdb commented 6 years ago

Nice, I must have been looking at an old version.

Can you lint all of your JS code with standard. c.f. https://github.com/summerofcode/gsoc-orgs/issues/19

Then squash your commits into a single commit if you want to. If you dont, I have to squash it, which means that I become the git Committer on your patch.