summerzhao / foursquared

Automatically exported from code.google.com/p/foursquared
Apache License 2.0
0 stars 0 forks source link

new checkins can be lost in PingService #205

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
1. turn on pings with no last known location (emulator's good for this)
2. check in a friend on another device
3. when PingService runs, it will not be able to get a location, so will not 
update anything; but it will still set PREFERENCE_PINGS_SERVICE_LAST_RUN_TIME
4. set a location (I used the emulator console)
5. when PingService runs again, it will see your friend's checkin, but will 
decide on the basis of PREFERENCE_PINGS_SERVICE_LAST_RUN_TIME that it's not new.

This is a pretty trivial fix, but I'm out of time for the morning.  I'll put a 
patch together tomorrow morning if nobody's fixed it by then.

Original issue reported on code.google.com by logan.jo...@gmail.com on 20 Jul 2010 at 12:24

GoogleCodeExporter commented 9 years ago
Well, I have a patch, but for the life of me I can't figure out how to send a 
pull request.

http://code.google.com/r/loganjohnson-foursquared/source/detail?r=b9d4c8f788a221
d7741eacb5d9124c7978f667a4

Original comment by logan.jo...@gmail.com on 22 Jul 2010 at 2:36

GoogleCodeExporter commented 9 years ago
Your fix will be in next release, thank you.

Original comment by mar...@gmail.com on 28 Jul 2010 at 7:47