[Improve] Align Github logo on footer and use <a> for Github footer

summitech / gitexplorer

Find the right git commands without digging through the web.

MIT License

1.84k stars 160 forks source link

[Improve] Align Github logo on footer and use <a> for Github footer #11

Closed viniciuskneves closed 5 years ago

viniciuskneves commented 5 years ago

I realized it while navigating through the page and when I went to click to check the Github repo I realized my mouse didn't switch to pointer and there wasn't a proper URL in that 'link'.

Then I found out it wasn't a link and it was firing a JS event. IMHO it is not necessary.

Are there any specific points where you should keep onClick instead of a?

viniciuskneves commented 5 years ago

Changes from https://github.com/summitech/gitexplorer/pull/13 merged here!