search

summitech / gitexplorer

Find the right git commands without digging through the web.
MIT License
1.84k stars 160 forks source link

prop-types package is not present in package.json #60

Closed jaworek closed 4 years ago

jaworek commented 4 years ago

I noticed that prop-types is used in the project is missing from package.json.

Was it overlooked? I can make a PR to fix it.

ade-fatimah commented 4 years ago

That should be an oversight. Yes you can create a PR. Thank you!

jaworek commented 4 years ago

Would it be ok if I also updated other dependencies? I think firebase is not used in the project, so I could remove it. I can add prettier if you don't mind. I'll also make separate with refactor and improvements.

ade-fatimah commented 4 years ago

Yeah, sure, you can do all these. Thanks a lot for the observations. Looking forward to seeing your PR

KoltonG commented 4 years ago

That is a great catch @jaworek! I saw that as well and wondered if there was something I was missing 😛. Do you need any help with creating the PR?

ade-fatimah commented 4 years ago

Thanks so much guys fro your PRs. It's very much appreciated. They've been merged.