Forcing animation of text could be simplified.

summitech / gitexplorer

Find the right git commands without digging through the web.

MIT License

1.84k stars 160 forks source link

Forcing animation of text could be simplified. #73

Closed jaworek closed 4 years ago

jaworek commented 4 years ago

Currently, to force animation of text to be repeated on option change application uses state in multiple places to do it. It is possible to simplify and improve it by using keys on components that need to be recreated when selected value changes. I'm happy to submit a PR, but from what I see this repo is not being updated for quite a while. Let me know if this repo still accepts changes.

ade-fatimah commented 4 years ago

The repo still accepts changes. Sincere apologies for the delays in merging but we accept changes and we promise it's going to be much faster now.

jaworek commented 4 years ago

Great! I'll submit a PR later.