summitto / pgp-packet-library

Implementation of binary PGP protocol, as per RFC 4880
GNU General Public License v3.0
27 stars 5 forks source link

Fix build on newer Ubuntu, add CI tests with g++ 11, Clang 14 #60

Closed runejuhl closed 2 years ago

runejuhl commented 2 years ago

This PR fixes builds under Ubuntu 22.04 and adds CI tests for g++ 11 and Clang 14. It also updates the existing CI jobs so that they run after the upstream images have been changed to have earlier compiler versions removed.


By making a contribution to this project, I certify that:

    (a) The contribution was created in whole or in part by me and I
        have the right to submit it under the GPL-3.0 license; or

    (b) The contribution is based upon previous work that, to the best
        of my knowledge, is covered under an appropriate open source
        license and I have the right under that license to submit that
        work with modifications, whether created in whole or in part
        by me, under GPL-3.0 license; or

    (c) The contribution was provided directly to me by some other
        person who certified (a), (b) or (c) and I have not modified
        it.

    (d) I understand and agree that this project and the contribution
        are public and that a record of the contribution (including all
        personal information I submit with it, including my sign-off) is
        maintained indefinitely and may be redistributed consistent with
        this project or the license(s) involved.
runejuhl commented 2 years ago

@rockhouse seems like appleclang 10 CI failed due to changes in upstream tooling/images?

xcrun: error: missing DEVELOPER_DIR path: /Applications/Xcode_10.3.app/Contents/Developer

Any idea how to fix this?

rockhouse commented 2 years ago

You can remove the macos workflow with name appleclang-10.0.1 as it is not available anymore in the macos-latest image. Then it should be fine. Also looked at the rest of your PR and happy to merge it but please also update the README regarding covered compilers!