search

summivox / thucal2

Tsinghua University curriculum -> iCalendar format (.ics) -> Google Calendar, etc.
http://userscripts.org/scripts/show/159785
22 stars 9 forks source link

Doesn't work when login via sslvpn outside of school #17

Open vuryleo opened 9 years ago

vuryleo commented 9 years ago

RT, The url of sslvpn is like https://sslvpn.tsinghua.edu.cn:11001/xkBks.vxkBksXkbBs.do?m=main, which is not satisfied with the pattern *.cic.tsinghua.edu.cn/syxk.vsyxkKcapb.do*. Besides, the urls in the param, such as http://zhjw.cic.tsinghua.edu.cn/jxmh.do, are different with what it is when login via sslvpn as well.

It will be a great pleasure if you can fix it :)

summivox commented 9 years ago

这种带proxy链接的我现在没法维护了……你们patch一下？

chenxiaoqino commented 9 years ago

Alpha version pushed to sslvpn_dev branch; please help testing.

wuuuuuud commented 9 years ago

应该没问题,openvpn-udp到日本试的 但是我这里greasemonkey不能通过打开.js的链接导入,必须手动添加,我怀疑是chrome安全性设置的问题

chenxiaoqino commented 9 years ago

增加了一点代码，继续等小规模测试，希望找到edge case bug。 过一段时间再融合进master吧

在 2014-9-23，下午11:06，wuuuuuud notifications@github.com 写道：

应该没问题,openvpn-udp到日本试的 但是我这里greasemonkey不能通过打开.js的链接导入,必须手动添加

— Reply to this email directly or view it on GitHub https://github.com/summivox/thucal2/issues/17#issuecomment-56534473.

summivox commented 9 years ago

代码风格：不要用tab字符，行尾不要留空格，tab stop = 2 其实thucal2.iced风格并不好。最近会想办法清理一下，但要留到下一个release。

另外你会squash么？提交patch的时候可以先squash（本地/你自己的fork）然后再PR进来，这样时间线会干净一些