sumn2u / learn-javascript

A book that teaches JavaScript 📗💻📖
https://javascript.sumankunwar.com.np
Apache License 2.0
920 stars 147 forks source link

add translated by section in credits.md #234

Closed sumn2u closed 2 months ago

sumn2u commented 2 months ago

Added translated by section in Spanish translation.

Screenshot 2024-09-07 at 11 59 22 AM

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 6:35pm
sumn2u commented 2 months ago

Hi @hamfree, can you review this PR?

hamfree commented 2 months ago

Hi, Sumn2u!

I'm at a loss for words. What do I have to revise? It's your book. I'm just one of the translators. Do what you think is best.

Anyway, thank you very much!

sumn2u commented 2 months ago

Hi, Sumn2u!

I'm at a loss for words. What do I have to revise? It's your book. I'm just one of the translators. Do what you think is best.

Anyway, thank you very much!

Could you please verify if the translation and the link I provided in this section are accurate? Once again, I truly appreciate your work in translating the book!

Screenshot 2024-09-07 at 1 16 30 PM
hamfree commented 2 months ago

The link, the name and the image is ok, but the content of the alt attribute would be "Fotografía del traductor". I'm not a girl, you know ... :-D

sumn2u commented 2 months ago

The link, the name and the image is ok, but the content of the alt attribute would be "Fotografía del traductor". I'm not a girl, you know ... :-D

My apologies. I've updated the text accordingly. It should be good now.

hamfree commented 2 months ago

All is ok now! Thanks!