sumoheavy / jira-ruby

A Ruby gem for the JIRA REST API
MIT License
654 stars 412 forks source link

#430 Upgrade webmock and tests #438

Closed bobbrodie closed 4 months ago

bobbrodie commented 4 months ago

Overview

The goal of this pull request is to upgrade to webmock 3.x. There are a few changes necessary to accomplish this:

Notes

The number of tests reported will drop, due to what I can tell are duplicates running in v1. Looking at the examples below, you'll see that webmock v1.x was running the shared tests twice. This has been remedied.

webmock v1.x

JIRA::Resource::Comment
  it should behave like a resource
    gracefully handles non-json responses
  it should behave like a resource with a collection GET endpoint
    should get the collection
  it should behave like a resource with a singular GET endpoint
    GETs a single resource
    builds and fetches a single resource
    handles a 404
  it should behave like a resource with a DELETE endpoint
    deletes a resource
  it should behave like a resource with a POST endpoint
    saves a new resource
  it should behave like a resource with a PUT endpoint
    saves an existing component
  it should behave like a resource
    gracefully handles non-json responses
  it should behave like a resource with a collection GET endpoint
    should get the collection
  it should behave like a resource with a singular GET endpoint
    GETs a single resource
    builds and fetches a single resource
    handles a 404
  it should behave like a resource with a DELETE endpoint
    deletes a resource
  it should behave like a resource with a POST endpoint
    saves a new resource
  it should behave like a resource with a PUT endpoint
    saves an existing component

webmock v3.x

JIRA::Resource::Comment
  it should behave like a resource
    gracefully handles non-json responses
  it should behave like a resource with a collection GET endpoint
    should get the collection
  it should behave like a resource with a singular GET endpoint
    GETs a single resource
    builds and fetches a single resource
    handles a 404
  it should behave like a resource with a DELETE endpoint
    deletes a resource
  it should behave like a resource with a POST endpoint
    saves a new resource
  it should behave like a resource with a PUT endpoint
    saves an existing component