search

sumotoy / RA8875

A library for RAiO RA8875 display driver for Teensy3.x or LC/Arduino's/Energia/Spark
GNU General Public License v3.0
79 stars 55 forks source link

rectHelper has one pixel error #17

Closed The-Experimentalist closed 9 years ago

The-Experimentalist commented 9 years ago

Your rectHelper function causes drawRect and fillRect to create rectangles larger in both height and width by 1 pixel

Should be:

rectHelper(x, y, x+w-1, y+h-1, color, true);

sumotoy commented 9 years ago

Oh, tanks! I'll check it out now!

sumotoy commented 9 years ago

Ok, it's true. Unfortunatly the solution will not so easy as you suggested. I'm actually fixed this issue but found some other functions affected so I'm currently fixing. The incoming 0.69 version have all corrections applied (probably today) but I have to touch some example that result heavy affected (the FFT for mention one). The main problem with RA8875 is that it's absolutely not out-of-range tolerant so if a value it's not in the range umpredictable results happens. Thanks again for catch this, I really appreciate help.