sumpfork / dominiontabs

Divider generator for the card game Dominion and its expansions.
http://domdiv.sandflea.org
Other
123 stars 125 forks source link

German Translation #160

Open ghost opened 7 years ago

ghost commented 7 years ago

The Card text and the card names are not available in German. Instead, I get the english texts

wvoigt commented 7 years ago

Correct. They need to be translated to German. See the file dominiontabs/domdiv/card_db/de/cards_de.json Any entry with "untranslated" needs a translation for the part listed. If you are able, we could use your help.

sumpfork commented 6 years ago

193

sumpfork commented 6 years ago

218 contributed a bunch more German translations, notably Nocture and Dark Ages.

sumpfork commented 5 years ago

233 added more

JanisBe commented 4 years ago

I just noticed this issue, I wrote about polish translation here https://github.com/sumpfork/dominiontabs/issues/263

alessandrofasse commented 2 years ago

Hey Sumpfork. I would like to assist you on this case. I saw that the translations for Menagerie are completely missing. That is why I created my own fork and a corresponding branch here.

I then added in the tests a small line to create the pdf file and to check if I am doing it correctly. However, for example the entry for "Black Cat", which I created here is not in the final pdf. I think the solution to the problem is easy. Can you give me a little hint? Then I will continue with the rest and also check/verify all other German translations.

sumpfork commented 2 years ago

Hey Sumpfork. I would like to assist you on this case. I saw that the translations for Menagerie are completely missing. That is why I created my own fork and a corresponding branch here.

I then added in the tests a small line to create the pdf file and to check if I am doing it correctly. However, for example the entry for "Black Cat", which I created here is not in the final pdf. I think the solution to the problem is easy. Can you give me a little hint? Then I will continue with the rest and also check/verify all other German translations.

It looks to me like you didn't run doit update_languages as mentioned here. This produces the version of the card database that actually gets packaged with the python code. Wenn ich das mache kriege ich eine "Schwarze Katze" im PDF ohne Probleme.

alessandrofasse commented 2 years ago

Many thanks for the help. I knew it was something simple that I overlooked :) Will continue with the rest and send a Pull Request :)

alessandrofasse commented 2 years ago

Added a pull request: https://github.com/sumpfork/dominiontabs/pull/365

poet-of-the-fall commented 1 year ago

Well, I already got all the texts for the German cards in my project but unfortunately in latex... But if it helps just copy whatever you need. My project is here: https://github.com/poet-of-the-fall/carddivider