Closed dkniffin closed 6 years ago
To note, this process has now been simplified.
Each language gets its own cards.json (https://github.com/sumpfork/dominiontabs/blob/master/card_db/en_us/cards.json) and mapping.json file in an appropriate folder. In the cards file, only name
, description
and cardset
need to be translated from the English version. In the mappings file, only a mapping from the new language's card set names to the English ones needs to be added (see the Italian at https://github.com/sumpfork/dominiontabs/blob/master/card_db/it/mapping.json). Then, --language=
card_groups.json can also be added, but is only needed for the special card grouping code (all Prizes under Prizes tab, etc.)
German is now available on the generator.
I currently update some german extra explanation and add also the adventure cards
Hi Peter, I hope i'm doing this correctly dominiontabs/card_db/nl-du/cards.json
@myrioi Doesn't seem like you've attached anything to your recent message. Did you mean to upload a file or something?
@nickv2002 yes i did but i don't know how to attach the file :(
@myrioi Below the text box where you type a message, there's a line that says "Attach Files by dragging & dropping or selecting them." I click on the "selecting them" text and that gives me a window to choose a file on my computer. Select one and then wait a second for it to upload. It should post in your message. Here's a test file I uploaded: test.txt
Hey Peter,
Myrioi has called upon one of her more tech savvy friends to help out. You can find the file here:
https://github.com/myrioi/dominiontabs/blob/patch-1/card_db/nl-du/cards.json
I've attached it here to be sure as well: Dominion-translation-NL.txt
(Which is basically a RAW version of the github file)
@myrioi @sumpfork I converted files into the new format that will be used for v2 cards. It is now included in Branch #105
There are three files now:
cards_nl_du.json
for card name and text. This is primarily what I converted from Dominion-translation-NL.txt
sets_nl_du.json
for set names. I extracted some of this information, but some remains to be translated.types_nl_du.json
for card type names. This needs to be translated.The last two files are short
types_nl_du.json
:
{
"Action": "Actie",
"Attack": "Attack",
"Blank": "Blank",
"Castle": "Castle",
"Curse": "Curse",
"Duration": "Duration",
"Event": "Event",
"Events": "Events",
"Expansion": "Expansion",
"Gathering": "Gathering",
"Landmark": "Landmark",
"Landmarks": "Landmarks",
"Looter": "Looter",
"Prize": "Prijs",
"Prizes": "Prijzen",
"Reaction": "Reaction",
"Reserve": "Reserve",
"Ruins": "Ruïne",
"Shelter": "Shelter",
"Shelters": "Shelters",
"Trash": "Vernietigde Kaarten",
"Traveller": "Traveller",
"Treasure": "Treasure",
"Victory": "Victory"
}
sets_nl_du.json
:
{
"adventures": {
"set_name": "Avonturen",
"text_icon": "Av"
},
"adventures extras": {
"set_name": "Avonturen Extras",
"text_icon": "Av"
},
"alchemy": {
"set_name": "Alchemisten",
"text_icon": "A"
},
"base": {
"set_name": "Basis",
"text_icon": "B"
},
"cornucopia": {
"set_name": "Overvloed",
"text_icon": "O"
},
"cornucopia extras": {
"set_name": "Overvloed Extras",
"text_icon": "O"
},
"dark ages": {
"set_name": "De Donkere Middeleeuwen",
"text_icon": "DM"
},
"dark ages extras": {
"set_name": "De Donkere Middeleeuwen Extras",
"text_icon": "DM"
},
"dominion1stEdition": {
"set_name": "Dominion 1st Edition",
"short_name": "Dominion",
"text_icon": "D1"
},
"dominion2ndEdition": {
"set_name": "Dominion 2nd Edition",
"short_name": "Dominion",
"text_icon": "D2"
},
"dominion2ndEditionUpgrade": {
"set_name": "Dominion 2nd Edition Upgrade",
"short_name": "Dominion",
"text_icon": "D2"
},
"empires": {
"set_name": "Empires",
"text_icon": "E"
},
"empires extras": {
"set_name": "Empires Extras",
"text_icon": "E"
},
"extras": {
"set_name": "Extras",
"text_icon": "X"
},
"guilds": {
"set_name": "Gilden",
"text_icon": "G"
},
"hinterlands": {
"set_name": "Achterland",
"text_icon": "Ac"
},
"intrigue1stEdition": {
"set_name": "Intrige 1st Edition",
"short_name": "Intrige",
"text_icon": "I1"
},
"intrigue2ndEdition": {
"set_name": "Intrige 2nd Edition",
"short_name": "Intrige",
"text_icon": "I2"
},
"intrigue2ndEditionUpgrade": {
"set_name": "Intrige 2nd Edition Upgrade",
"short_name": "Intrige",
"text_icon": "I2"
},
"promo": {
"set_name": "Promo",
"text_icon": "Pm"
},
"prosperity": {
"set_name": "Welvaart",
"text_icon": "W"
},
"seaside": {
"set_name": "Hijs De Zeilen",
"text_icon": "HZ"
}
}
If it is easier, paste the translations of these files here and I can update.
Hi i'm so sorry this took so long. But i finally finished translating everything. Here are the files. Could you upload them in the generator so i can do a spellcheck? Dominion-translation-NL.txt sets.txt types.txt
Also is there by change a possibility to set the cards in alphabetical order in the dutch names? Do I change the order in the file or is there an other way
Can I close this? #105 got landed a long time ago, and we've had other Dutch translations since then. Or are there valuable translated bits in here that got missed?
Hi Peter,
I submitted the full translation a few months ago, but probably at the wrong place. I’m happy to hear that other Dutch people have picked up my mess. I just check the generator and I see that the empires set is not translated to Dutch in this set. I put my translated files in this mail, in it I also did the empires set. If you want I can translate the nocturne set in the future once I have it, but maybe you can tell me where I can best submit it once I’m finished, because I clearly don’t understand the website.
With kind regards,
Pita van Deurzen
Van: Petermailto:notifications@github.com Verzonden: dinsdag 16 januari 2018 07:43 Aan: sumpfork/dominiontabsmailto:dominiontabs@noreply.github.com CC: myrioimailto:p.vandeurzen@hotmail.com, Mentionmailto:mention@noreply.github.com
Can I close this? #105https://github.com/sumpfork/dominiontabs/pull/105 got landed a long time ago, and we've had other Dutch translations since then. Or are there valuable translated bits in here that got missed?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sumpfork/dominiontabs/issues/21#issuecomment-357867739, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT7uwkjV3wQ2cQJc9j18IpDjFDY1n8oqks5tLEUWgaJpZM4F386-.
{ "Action": "Actie", "Attack": "Aanval", "Blank": "Blank", "Castle": "Kasteel", "Curse": "Vloek", "Duration": "Duurzaam", "Event": "gebeurtenis", "Events": "Gebeurteniskaarteb", "Expansion": "Uitbreiding", "Gathering": "Verzamel", "Landmark": "Bezienswaardigheid", "Landmarks": "Bezienswaardigheidskaarten", "Looter": "Looter", "Prize": "Prijs", "Prizes": "Prijzen", "Reaction": "Reactie", "Reserve": "Reserve", "Ruins": "Ruïne", "Shelter": "Onderdak", "Shelters": "Onderdakkaarten", "Trash": "Vernietigde Kaarten", "Traveller": "Traveller", "Treasure": "Geld", "Victory": "Victory" }
{
"adventures": {
"set_name": "Avonturen",
"text_icon": "Av"
},
"adventures extras": {
"set_name": "Avonturen Extras",
"text_icon": "Av"
},
"alchemy": {
"set_name": "Alchemisten",
"text_icon": "A"
},
"base": {
"set_name": "Basis",
"text_icon": "B"
},
"cornucopia": {
"set_name": "Overvloed",
"text_icon": "O"
},
"cornucopia extras": {
"set_name": "Overvloed Extras",
"text_icon": "O"
},
"dark ages": {
"set_name": "De Donkere Middeleeuwen",
"text_icon": "DM"
},
"dark ages extras": {
"set_name": "De Donkere Middeleeuwen Extras",
"text_icon": "DM"
},
"dominion1stEdition": {
"set_name": "Dominion 1st Edition",
"short_name": "Dominion",
"text_icon": "D1"
},
"dominion2ndEdition": {
"set_name": "Dominion 2nd Edition",
"short_name": "Dominion",
"text_icon": "D2"
},
"dominion2ndEditionUpgrade": {
"set_name": "Dominion 2nd Edition Upgrade",
"short_name": "Dominion",
"text_icon": "D2"
},
"empires": {
"set_name": "Kijzerrijken",
"text_icon": "E"
},
"empires extras": {
"set_name": "Kijzerrijken Extras",
"text_icon": "E"
},
"extras": {
"set_name": "Extras",
"text_icon": "X"
},
"guilds": {
"set_name": "Gilden",
"text_icon": "G"
},
"hinterlands": {
"set_name": "Achterland",
"text_icon": "Ac"
},
"intrigue1stEdition": {
"set_name": "Intrige 1st Edition",
"short_name": "Intrige",
"text_icon": "I1"
},
"intrigue2ndEdition": {
"set_name": "Intrige 2nd Edition",
"short_name": "Intrige",
"text_icon": "I2"
},
"intrigue2ndEditionUpgrade": {
"set_name": "Intrige 2nd Edition Upgrade",
"short_name": "Intrige",
"text_icon": "I2"
},
"promo": {
"set_name": "Promo",
"text_icon": "Pm"
},
"prosperity": {
"set_name": "Welvaart",
"text_icon": "W"
},
"seaside": {
"set_name": "Hijs De Zeilen",
"text_icon": "HZ"
}
}
[
{
"cardset": "dominion",
"cost": "2",
"description": "+1 Actie\nLeg een aantal kaarten naar keuze af. +1 kaart per afgelegde kaart.",
"extra": " Je kunt de Kelder zelf niet afleggen, omdat deze na het spelen ervan niet meer in je hand zit. Je mag wel een andere Kelderkaart afleggen als je deze in je hand hebt. Je kiest zelf welke kaarten je aflegt en legt ze allemaal tegelijk af. Je mag pas nieuwe kaarten trekken nadat je alle kaarten hebt afgelegd. Als je tijdens het trekken van nieuwe kaarten de aflegstapel moet schudden, worden de door de Kelder afgelegde kaarten meegeschud.",
"name": "Kelder",
"potcost": 0,
"types": [
"Action"
]
},
{
"cardset": "dominion",
"cost": "2",
"description": "Vernietig 4 of minder kaarten uit je hand.",
"extra": " Je kunt de Kapel zelf niet afleggen, omdat deze na het spelen ervan niet in je hand is. Je mag wel een andere Kapelkaart afleggen als je deze in je hand hebt.",
"name": "Kapel",
"potcost": 0,
"types": [
"Action"
]
},
{
"cardset": "dominion",
"cost": "2",
"description": "+2 kaarten\n__\nAls een andere speler een aanvalskaart speelt, mag je de Slotgracht tonen. In dat geval heeft de aanval op jou geen effect.",
"extra": " Een aanvalskaart is een kaart met de aanduiding \"Aanval\" (meestal, \"Actie - Aanval\"). Als een andere speler een aanvalskaart speelt, mag je de Slotgracht aan de andere spelers tonen en deze daarna terug in je hand doen (voordat de gevolgen van de aanvalskaart zijn uitgevoerd). Je wordt in dat geval niet door de aanvalskaart getroffen. De andere spelers hebben geen voordeel van jouw Slotgracht. Voorbeeld: als een speler een Heks speelt en alle andere spelers laten een Slotgracht zien, moet de speler die de Heks speelde, alsnog 2 kaarten trekken. Je mag de Slotgracht ook in je eigen beurt spelen om 2 kaarten te trekken.",
"name": "Slotgracht",
"potcost": 0,
"types": [
"Action",
"Reaction"
]
},
{
"cardset": "dominion",
"cost": "3",
"description": "+2 Coins\nJe mag je trekstapel direct op je aflegstapel leggen.",
"extra": " Je moet de Raadsheer uitvoeren (beslissen of je je hele trekstapel op de aflegstapel legt), voordat je iets anders in je beurt doet (zoals een andere kaart spelen of kopen). Je mag je trekstapel niet tijdens het afleggen doorkijken.",
"name": "Raadsheer",
"potcost": 0,
"types": [
"Action"
]
},
{
"cardset": "dominion",
"cost": "3",
"description": "+1 Kaart\n+2 Acties.",
"extra": " Als je meerdere Dorpen speelt, houd het aantal extra acties dan hardop bij. Dit werkt altijd.",
"name": "Dorp",
"potcost": 0,
"types": [
"Action"
]
},
{
"cardset": "dominion",
"cost": "3",
"description": "+1 Aanschaf\n+2 Coins.",
"extra": " Je mag tijdens je aankoopfase een extra actiekaart uit de voorraad kopen. Je hebt in deze beurt 2 geld meer tot je beschikking.",
"name": "Houthakker",
"potcost": 0,
"types": [
"Action"
]
},
{
"cardset": "dominion",
"cost": "3",
"description": "Pak een kaart die maximaal 4 Coins kost.",
"extra": " Kies de kaart uit de voorraad. Leg de gekozen kaart op je aflegstapel. Je kunt geen geld van geldkaaten of gespeelde acties gebruiken om de waarde van de gekozen kaart te verhogen.]",
"name": "Werkplaats",
"potcost": 0,
"types": [
"Action"
]
},
{
"cardset": "dominion",
"cost": "4",
"description": "Leg uit de algemene voorraad een zilverkaart op je trekstapel. Iedere andere speler legt een overwinningskaart uit zijn hand op zijn trekstapel (of laat zien dat hij deze niet heeft).",
"extra": " Als je geen kaarten in je trekstapel hebt op het moment dat je de bureaucraat speelt, wordt de zilverkaart die je ontvangt, de enige kaart in je trekstapel. Hetzelfde geldt voor een andere speler zonder kaarten in zijn trekstapel. De overwinningskaart die hij bovenop legt, wordt de enige kaart in zijn trekstapel.",
"name": "Bureaucraat",
"potcost": 0,
"types": [
"Action",
"Attack"
]
},
{
"cardset": "dominion",
"cost": "4",
"description": "Vernietig deze kaart. Pak een kaart met een waarde van 5 Coins of minder.",
"extra": " Je moet de kaart uit de voorraad kiezen. Leg de gekozen kaart op je aflegstapel. Je kunt geen geld van geldkaarten of gespeelde acties gebruiken om de waarde van de gekozen kaart te verhogen. Als je de troonzaal in combinatie met het feest gebruikt, mag je twee kaarten kiezen, hoewel je het feest maar één keer kunt vernietigen. Het is niet verplicht om een kaart te kiezen, nadat je het Feest hebt vernietigd.",
"name": "Feest",
"potcost": 0,
"types": [
"Action"
]
},
{
"cardset": "dominion",
"cost": "4",
"description": "Elke 10 kaarten in je stapel zijn aan het einde van het spel 1
Hi, instead of checking the online generator (which I haven't pushed the latest code to), could you check the files at https://github.com/sumpfork/dominiontabs/tree/master/domdiv/card_db/nl_du to see what's current?
Also, the ideal way to submit more translations is via github pull requests, after making sure that the language works locally. I know that may be too cumbersome, but the truth is that I don't often get to manually submitted files as they often require quite a bit of work to fix up. I should maybe make an issue per language so that others can see the current state of one, collect files there, and help out.
I checked the link and most cards of Empires are translated. The once that are not are card that don't get printed (the individual traveller cards).
I will ask my tach savvy friend to explain the pull request and how I should do the translation in the way its meant to be done for the nocturne expansion.
Any indication when the empires translation will be added to the online generator?
With kind regards,
Pita van deurzen
Van: Petermailto:notifications@github.com Verzonden: dinsdag 16 januari 2018 21:35 Aan: sumpfork/dominiontabsmailto:dominiontabs@noreply.github.com CC: myrioimailto:p.vandeurzen@hotmail.com, Mentionmailto:mention@noreply.github.com
Hi, instead of checking the online generator (which I haven't pushed the latest code to), could you check the files at https://github.com/sumpfork/dominiontabs/tree/master/domdiv/card_db/nl_du to see what's current?
Also, the ideal way to submit more translations is via github pull requests, after making sure that the language works locally. I know that may be too cumbersome, but the truth is that I don't often get to manually submitted files as they often require quite a bit of work to fix up. I should maybe make an issue per language so that others can see the current state of one, collect files there, and help out.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sumpfork/dominiontabs/issues/21#issuecomment-358096547, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT7uwmDwE6_G7-Kubs9aeQ77l8g6lFWbks5tLQgXgaJpZM4F386-.
Sorry it took so long, but the Empires translation is now live. I'm closing this issue and would like to have per-language tracking issues in the future.
Boardgamegeek.com has a bunch translated instruction books. It might be possible to use those to add additional languages to this project.