sumpfork / dominiontabs

Divider generator for the card game Dominion and its expansions.
http://domdiv.sandflea.org
Other
123 stars 126 forks source link

github clone asking for amazonaws authentication #457

Closed mr-ice closed 1 year ago

mr-ice commented 1 year ago

I noticed a problem with authentication in the git pull (this example is on my fork)

% git pull
remote: Enumerating objects: 642, done.
remote: Counting objects: 100% (392/392), done.
remote: Compressing objects: 100% (189/189), done.
remote: Total 642 (delta 208), reused 351 (delta 195), pack-reused 250
Receiving objects: 100% (642/642), 30.83 MiB | 4.18 MiB/s, done.
Resolving deltas: 100% (280/280), completed with 55 local objects.
From https://github.com/mr-ice/dominiontabs
 + 64a65be...db4b200 main       -> origin/main  (forced update)
Username for 'https://a9ttshyzgd.execute-api.us-west-2.amazonaws.com':

But this happens when doing a fresh clone of yours too:

% git clone https://github.com/sumpfork/dominiontabs
Cloning into 'dominiontabs'...
remote: Enumerating objects: 4540, done.
remote: Counting objects: 100% (263/263), done.
remote: Compressing objects: 100% (212/212), done.
remote: Total 4540 (delta 57), reused 213 (delta 42), pack-reused 4277
Receiving objects: 100% (4540/4540), 64.80 MiB | 4.38 MiB/s, done.
Resolving deltas: 100% (2310/2310), done.
Username for 'https://a9ttshyzgd.execute-api.us-west-2.amazonaws.com':

I'm going to try to ^c the authentication and proceed, but not sure what part i'll be interrupting.

Should someone be able to clone without providing this authentication? If not, how should we provide the authentication?

mr-ice commented 1 year ago

As you can imagine, this is from the lfs configuration:

% cat .lfsconfig
[remote "origin"]
        lfsurl = https://a9ttshyzgd.execute-api.us-west-2.amazonaws.com/prod

and

% grep -A2 aws .git/config
[lfs "https://a9ttshyzgd.execute-api.us-west-2.amazonaws.com/prod"]
        access = basic
mr-ice commented 1 year ago

getting it on python setup.py develop as well:

% bin/python setup.py develop
/Users/michael/project/DominionDividers/dominiontabs/lib/python3.9/site-packages/setuptools/__init__.py:85: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated. Requirements should be satisfied by a PEP 517 installer. If you are using pip, you can try `pip install --use-pep517`.
  dist.fetch_build_eggs(dist.setup_requires)
running develop
/Users/michael/project/DominionDividers/dominiontabs/lib/python3.9/site-packages/setuptools/command/easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/Users/michael/project/DominionDividers/dominiontabs/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
running egg_info
writing src/domdiv.egg-info/PKG-INFO
writing dependency_links to src/domdiv.egg-info/dependency_links.txt
writing entry points to src/domdiv.egg-info/entry_points.txt
writing requirements to src/domdiv.egg-info/requires.txt
writing top-level names to src/domdiv.egg-info/top_level.txt
Username for 'https://a9ttshyzgd.execute-api.us-west-2.amazonaws.com':
mr-ice commented 1 year ago

I see this in the README:

There is a [directory of source images](img_sources/) at the top level of the directory. While these are optional, they can be useful reference and/or used for creating new or recreating old tab banners, icons, etc. Many of these were originally scans of the physical game. Some of them have a lot of layers and are approaching 1GB in size, so they are hosted via [Git LFS](https://git-lfs.com/). As the Github version of that incurs a higher monthly cost, I instead host them on a private LFS server. If you would like the images or would like to contribute images let me know and I can make you an account on said server, or you I can copy them for you for easier access.

This gives me a hint that I can remove that config and perhaps get it back to working.

sumpfork commented 1 year ago

Yeah, thanks, I'm aware as CI is breaking, too. I'll try to find time to fix it this weekend, but for now just remove the fit lfs configuration locally - you shouldn't need the image sources anyway.

mr-ice commented 1 year ago

Thanks @sumpfork ,

I tried that, but all steps are restoring it (such as python setup.py develop) and running into this problem again.

I'll try working from a git checkout --force 347adf06

sumpfork commented 1 year ago

I moved the image sources to https://github.com/sumpfork/dominiontabs_img_sources. Can you check that this fixes the main repo for you?

mr-ice commented 1 year ago

All good!