search

sumpfork / dominiontabs

Divider generator for the card game Dominion and its expansions.
http://domdiv.sandflea.org
Other
123 stars 126 forks source link

PullTab Error #513

Open Kelanen2002 opened 6 months ago

Kelanen2002 commented 6 months ago

When I try and create a set of PullTabs for a few sets I get {Message: Internal server error}.

Works on a single set.

sumpfork commented 6 months ago

Seems to work fine for me, any other settings that are non-default?

Kelanen2002 commented 6 months ago

Yes, quite a few

A4, 3 tabs, 3.0 cm tabs, black tabs, don't restart tabs, add cost, add type - I think that's it.

Any other divider type works fine even for a full set, but PullTabs seems to work for 1-2, but fail at 5 or so (having come down from a full set...)

Kelanen2002 commented 6 months ago

Actually it doesn't work on other types, it just appears to - it creates the file but with ~26 pages and 2.5 sets, not the 150-200 pages it should be. Memory issue?

Maybe I just need to do a set at a time....

sumpfork commented 6 months ago

I upped the memory and CPU by 4x, but you're right, with a full set of sets I still get errors.

It's hitting the 6MB response size limit of AWS Lambdas.

I'll have to do work to fix this. Options that come to mind are 1) provide a download link instead of returning the file if the file is too big, or 2) adapt response streaming (maybe through lambda web adaptor?)

It'll be some work in either case, so don't hold your breath. I guess generate batch of expansions for now.

Kelanen2002 commented 6 months ago

First option seems easiest - just give a link if it's more than one set selected.

But thanks for investigating