search

sumtxt / bonn

Data retrieval client for the INKAR Database (https://www.inkar.de)
15 stars 1 forks source link

IDs for Indicators are not static #1

Open fmssn opened 1 year ago

fmssn commented 1 year ago

Obviously as the JSON API is undocumented, they are not bound to the IDs static. I got a rude awakening when this morning my reachability indicators suddenly changed to unemployment rates.

This is clearly not in your responsibility, yet I think it would be beneficial to add this information to the readme, just so people should increase their test coverage to cover this possible problem.

sumtxt commented 1 year ago

Not sure I follow. Can you explain what changed?

fmssn commented 1 year ago

As an example, previously, the average driving time to the next airport was accessible by calling get_variables(theme="335", geography="KRE"). Now this instead gives "Nicht erwerbsfähige SGBII-Leistungsberechtigte unter 15 Jahren je 100 Einwohner unter 15 Jahren", whatever that means. Instead it is now accessible by calling get_variables(theme="346", geography="KRE").

fmssn commented 1 year ago

Such changes were prevalent with next to all indicators I am using.

sumtxt commented 1 year ago

Oh, ok! Thanks for sharing. I will put a note in the Readme.

bathyscapher commented 1 year ago

I likely would have overlooked this and would have ended up with wrong data, if the ID used so far (get_data(variable = '111', geography = "GVB") would not have been completely vanished.

Is there a way to fix the IDs to a certain variable?

Or is KurznamePlus invariant? So it would be possible to dynamically fetch the ID by a variable name (such as fetch the ID of Einwohner unter 6 Jahre).

sumtxt commented 1 year ago

This is not an issue with the package but their (undocumented) API.

bathyscapher commented 1 year ago

I see. Do you know if the values of KurznamePlus remains the same over time?

sumtxt commented 1 year ago

I don't know.

bathyscapher commented 1 year ago

Okay, thank you though :)