Closed connor-baer closed 3 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
oss-circuit-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 5, 2024 11:31am |
Latest commit: 4288256724c1c8d1898b0bc038f00fd603f3ee67
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Attention: Patch coverage is 40.00000%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 86.59%. Comparing base (
0dbd4c9
) to head (4288256
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
packages/circuit-ui/components/Toggle/Toggle.tsx | 40.00% | 12 Missing :warning: |
Purpose
The Toggle's
checkedLabel
anduncheckedLabel
props were meant to communicate the component's state. They were rendered inside thebutton
. However, users could never perceive them: they're visually hidden and are overridden by thearia-labelledby
attribute on thebutton
.Approach and changes
checkedLabel
anduncheckedLabel
props since they are no longer needed. They will be removed in the next major.Definition of done