sumup-oss / circuit-ui

SumUp's design system for the web
https://circuit.sumup.com
Apache License 2.0
922 stars 129 forks source link

fix(circuit-ui): ColorInput paste and change events #2687

Closed matoous closed 1 month ago

matoous commented 2 months ago

Improve ColorInput, specifically:

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: db0b4013263a032be39a5df1be5d6605843a0b53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @sumup/circuit-ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 11:54am
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.74%. Comparing base (14643b2) to head (db0b401). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/circuit-ui/components/ColorInput/ColorInput.tsx 96.15% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sumup-oss/circuit-ui/pull/2687/graphs/tree.svg?width=650&height=150&src=pr&token=xqWZUwlDHL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sumup-oss)](https://app.codecov.io/gh/sumup-oss/circuit-ui/pull/2687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sumup-oss) ```diff @@ Coverage Diff @@ ## main #2687 +/- ## ========================================== + Coverage 86.63% 86.74% +0.11% ========================================== Files 210 210 Lines 12000 12043 +43 Branches 1507 1520 +13 ========================================== + Hits 10396 10447 +51 + Misses 1551 1543 -8 Partials 53 53 ``` | [Files with missing lines](https://app.codecov.io/gh/sumup-oss/circuit-ui/pull/2687?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sumup-oss) | Coverage Δ | | |---|---|---| | [...es/circuit-ui/components/ColorInput/ColorInput.tsx](https://app.codecov.io/gh/sumup-oss/circuit-ui/pull/2687?src=pr&el=tree&filepath=packages%2Fcircuit-ui%2Fcomponents%2FColorInput%2FColorInput.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sumup-oss#diff-cGFja2FnZXMvY2lyY3VpdC11aS9jb21wb25lbnRzL0NvbG9ySW5wdXQvQ29sb3JJbnB1dC50c3g=) | `98.10% <96.15%> (+7.66%)` | :arrow_up: |
matoous commented 1 month ago

@connor-baer can I merge? Or anything left? 🙈

connor-baer commented 1 month ago

@matoous Feel free to merge :shipit: