search

sumup / global-stylesheets

1 stars 2 forks source link

demo commit #7

Closed spyros-papavlasopoulos closed 8 years ago

spyros-papavlasopoulos commented 8 years ago

added some helper classes

nilsborg commented 8 years ago

Ehm guys, I know I'm just gonna make myself unpopular again, but I'll just ask anyway: What is this about? Are switching from doing stuff in css to a more bootstrap (we have classes and distribute them all over the markup) kind of way? Because if so, this is a huge change and will (since these are the GLOBAL styles) affect not only the marketing website. @mlent what do you think about this?

mlent commented 8 years ago

What Nils said.

These styles are shared between projects, and while I agree that our current CSS "practices" are not optimal for the most part (e.g. the fact that a lot of the CSS is just DOM mirroring) -- let's talk about how we actually want to move forward, thinking about all the web components that rely on these styles, establish some best practices, and enforce them on one another.

I say we do that once the static site is launched -- then we'll have some time to think about how to optimize it to the moon :)