search

sumup / sumup-ios-sdk

Other
46 stars 25 forks source link

Impossible to implement this SDK in any app (Nav bar color issues) #121

Open TillMoss opened 1 year ago

TillMoss commented 1 year ago

The problem is that you are touching "appearance()" of entire UI of the app. This causes a lot of issue, some labels become invisible, navigation bar in dark mode becomes white and many other issue. NEVER touch UI appearance! NEVER!

ralfebert commented 1 year ago

Same here, just adding the SumupSDK changes the navigation bar colors to white in the complete app, so they become white even in dark mode. I also think the SumUpSDK shouldn't touch UIAppearance at all.

flipbosch commented 1 year ago

Same problem here, in all sheets the navigation bar is white now while app is in Dark mode:

image

omerguen commented 1 year ago

Same Problem here. Are there any suggestions?

jadeburton-sumup commented 1 year ago

We've just released version 4.3.3, which contains a fix for this UIAppearance problem. Please let me know if this does not fix the issue for you.

ralfebert commented 1 year ago

@jadeburton-sumup v4.3.3 does not fix the issue for me, after calling into Sumup (just logging in to show the list of payment methods and cancelling), the navigation bars become white in Dark Mode for the whole app. The bug only occurs for scrollable views in their scrolled-down state after the navigation bar changes from being inline to an overlay.

jadeburton-sumup commented 1 year ago

Alright @ralfebert thanks for checking this. We will need more time to find the cause of this; the UIAppearance code we removed apparently wasn't it.

staninprague commented 1 year ago

Has this been fixed? I'm trying now to integrate into my taximeter app and don't see any UIAppearance effects from SumUp on my app. I'm having black UINavigationBars (UIKit), they stay black.

jadeburton-sumup commented 1 year ago

Hi @staninprague, the last thing that changed in this area was in 4.3.3, and @ralfebert reported that it was not fixed in that version. I don't have a timeframe for a fix at this stage.