sumup / sumup-ios-sdk

Other
46 stars 24 forks source link

"Server error" message when Geolocating is disabled #66

Open Ceroce opened 6 years ago

Ceroce commented 6 years ago

Hi,

My colleagues in our support team reported that they could not make a payment, and were getting a "Server error" message.

sumuperreurserveur

The SDK only returned a generic error code 50 (SMPSumUpSDKErrorCheckoutGeneral), and SumUp's french support really had no clue about the cause. Finally I got in contact with someone in Germany who told me that the error may occur because the iPad could not be Geolocated. This proved to be the right reason: the authorization to access the user's location was set to "Never" on the iPad of our support team.

The error message is very misleading, and there is a large amount of chance that us programmers using the SDK are not aware that the user refusing access to the position will cause transactions to fail.

It's probably impractical that the SDK requests itself the access to the device's location, since it does not know which kind of access ("While in front" or "Always") the app might need.

But at the very least it ought to report the error in a clear and unmissable way. The documentation should also mention that the app must check that geolocating is allowed before issuing a payment.

JullianSU commented 6 years ago

Hello,

Thank you for reporting the issue, we are now aware of the problem and will update accordingly to avoid confusion.

Many thanks,

Ceroce commented 5 years ago

Hi Houcin,

View Controllers of the SDK show in the same language than the rest of the app. Hence, if you want the SumUp panels to show in French, your app must have a French localization.

Renaud

Le 4 déc. 2018 à 18:14, houcin notifications@github.com a écrit :

Hi,

@Ceroce https://github.com/Ceroce I passed one day because of exactly the same issue :/ It would be very nice to have more explicits messages...

Could you please tell me how did you manage to display your app in french usign the sdk ? I used the [SMPSumUpSDK setAccessibilityLanguage:@"fr-FR"]; with no succes...

Thanks in advance.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sumup/sumup-ios-sdk/issues/66#issuecomment-444180472, or mute the thread https://github.com/notifications/unsubscribe-auth/ABhiN8oIGtkTOdrYRdCoqu9uDJ-vw5UPks5u1q14gaJpZM4WFQOl.

thomascube commented 5 years ago

@JullianSU Any progress on this issue? Is there an ETA for a new release fixing this?

Alkashi commented 5 years ago

Hi @Ceroce,

Yep, I found it just after publishing my question. Thanks for the feedback :)

@thomascube apparently not... :/

Hi Houcin, View Controllers of the SDK show in the same language than the rest of the app. Hence, if you want the SumUp panels to show in French, your app must have a French localization. Renaud Le 4 déc. 2018 à 18:14, houcin @.***> a écrit : Hi, @Ceroce https://github.com/Ceroce I passed one day because of exactly the same issue :/ It would be very nice to have more explicits messages... Could you please tell me how did you manage to display your app in french usign the sdk ? I used the [SMPSumUpSDK setAccessibilityLanguage:@"fr-FR"]; with no succes... Thanks in advance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABhiN8oIGtkTOdrYRdCoqu9uDJ-vw5UPks5u1q14gaJpZM4WFQOl.

thomascube commented 4 years ago

@JullianSU, @mollidor yet another year passed without any progress on this issue. What are your release plans and cycles? Is this so hard to fix?