search

sumuzhao / CycleGAN-Music-Style-Transfer-Refactorization

Symbolic Music Genre Transfer with CycleGAN - Refactorization
MIT License
34 stars 16 forks source link

bug fix #6

Open zijiebite opened 3 years ago

zijiebite commented 3 years ago
  1. A tiny bug : in file tf2_model.py , from line 35 to 51 . It is obvious that the name and value of the args do not match. An easy fix : see the file "tf2_model.py" in the .zip attached
  2. A better (maybe) coding : in file tf2_module.py , function "build_generator" , line 152 to 162. The layer "PADDING_1" is not actually needed, if we only concern about the intelligibility of the code . I recommend to just alter the argument "padding" of Conv2D from 'valid' to 'same'. Actually you used " padding='same' " in the function "build_discriminator".

fix_zijiebite.zip

sumuzhao commented 3 years ago

Hi, thanks for your comments. Could you just pull a request that I can merge them directly?

zijiebite commented 3 years ago

Sure!

brkayaoglu commented 3 years ago

If you trained all dataset, did you get the testable result @zijiebite ? If you get, can you share with me ? Thanks.