Open TheChaosium opened 2 years ago
I see how we can fix it, but it will need us to migrate over the runes from the Starter Set version to this. @wake42 is that what you want me to look at next?
I must admit I'm still not sure where you mean you can open the opposing rune. If you open a Rune Item Sheet you get a dropdown menu to select opposing / minor runes. But you can't open the opposing rune.
If you mean the list of runes on the Character Sheet you still can only open the rune sheet for the rune you click on (by right clicking and selecting edit rune). . But if you change the name of a rune (for example Fire -> Fire/Sky) then the layout of the runes tab will break. There is a case for fixing that by using rqids to identify what should go where instead of using the rune name #123.
Not sure if this works, but I know how to change it so that when you click on the Fire/Sky Rune (that is the name for it the Rune sadly) it will open up that room by storing the rqid structure like we do with description.
On Mon, Jul 11, 2022 at 7:40 AM 'Åke Wivänge' via The Foundry < @.***> wrote:
I must admit I'm still not sure where you mean you can open the opposing rune. If you open a Rune Item Sheet you get a dropdown menu to select opposing / minor runes. But you can't open the opposing rune. [image: image] https://user-images.githubusercontent.com/4853677/178194239-126f74b8-d152-472e-8078-9f75b30fb2e7.png
If you mean the list of runes on the Character Sheet you still can only open the rune sheet for the rune you click on (by right clicking and selecting edit rune). [image: image] https://user-images.githubusercontent.com/4853677/178194945-b53e6766-2c9e-4228-8f28-4b6a69fdb97e.png . But if you change the name of a rune (for example Fire -> Fire/Sky) then the layout of the runes tab will break. There is a case for fixing that by using rqids to identify what should go where instead of using the rune name
123 https://github.com/sun-dragon-cult/fvtt-system-rqg/issues/123.
— Reply to this email directly, view it on GitHub https://github.com/sun-dragon-cult/fvtt-system-rqg/issues/277#issuecomment-1179988180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWZECO45KGLBNEUTHYFA3T3VTOXTRANCNFSM53EZO7RA . You are receiving this because you authored the thread.Message ID: @.***>
-- NEIL ROBINSON : COO, Chaosium, Inc. email: @.*** web: www.chaosium.com phone: 206-963-6074 skype: orlanthifool
Are you talking about linking to the journal entry description? That is currently broken due to the in progress rqid changes (see #278)? Could you post a screenshot of "where you are".
In the screenshot above, it would be here
It would be good to be able to open the linked runes in the rune sheet by clicking on them. That way it will be faster to edit opposed runes for example.
The data needed for the link is already there, at least after the refactoring to use rqid instead of rune names. So adding a click handler that can open the linked rune should be easy.
Blocked by