search

sun-dragon-cult / fvtt-system-rqg

Runequest Glorantha Foundry VTT system
https://sun-dragon-cult.github.io/
Other
20 stars 2 forks source link

Loosen duplicate embedded item check #672

Closed wake42 closed 12 months ago

wake42 commented 12 months ago

Adding two javelins currently require you to rename them so they have unique names. Also splitting your currency into multiple piles requires that you rename your Lunars items to have unique names. Unique Physical Items do not have quantity (locked to 1) but it should still be possible to have more of them as separate items.

There is a check that all items (except RuneMagic) has to be unique <type+name> (see rqgItem.isDuplicateItem). RuneMagic was removed from the check since you must be able to have the same spell learned from multiple cults. The physical items (gear, armor & weapon) should also be excluded from this uniqueness check.

Moonpile commented 12 months ago

Unique Physical Items do not have quantity (locked to 1)

I've always found this strange. I don't mind being able to have, say, 7 broadswords or 4 helmets.

wake42 commented 12 months ago

The problem with having 7 broadswords is for example that you can't equip and fight with 7 broadswords, and if you would do that and the broadsword looses HP then all 7 will loose it because they are the same item (with a quantity number).

From what I can see the only downside is that you can't have a merchant with 7 broadswords for sale, but to handle all the complexity that comes with allowing quantity on these kinds of items doesn't seem reasonable to me. See #211 for more discussion about the obstacles with allowing it.

Moonpile commented 12 months ago

I know we've discussed this many times. I'd be ok with the side-effect of all 7 broadswords lose hit points. Maybe just have a warning pop up if you equip something and there's a quantity other than 1.