search

sun-dragon-cult / fvtt-system-rqg

Runequest Glorantha Foundry VTT system
https://sun-dragon-cult.github.io/
Other
20 stars 2 forks source link

Negative Damage Reported in Combat #705

Open claycle opened 7 months ago

claycle commented 7 months ago

Negative Damage in Combat

It appears that damage, when penalized by a negative damage bonus (small/weak characters) is being allowed to go negative.

To Reproduce

Steps to reproduce the behavior:

  1. Create a character with a negative damage bonus.
  2. Make some attacks and damage rolls.

Expected behavior

Damage calculations less than 0 should be 0.

Screenshots

Screenshot 2024-04-20 at 8 00 13 PM

Environment - please paste the information from foundry settings tab "support" button:

Foundry Virtual Tabletop: Version 11 Stable, 11.315 Game System: rqg, 3.4.2 Active Modules: 41 Performance Mode: 2

OS: Unknown Client: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36 Edg/124.0.0.0 GPU: ANGLE (ATI Technologies Inc., AMD Radeon Pro Vega 64 OpenGL Engine, OpenGL 4.1) Max Texture Size: 16384

Scene: 3000 x 3000 | Grid Size: 100 | Padding Percentage: 0.25 Walls: 44 | Ambient Lights: 4 | Ambient Sounds: 1 | Tiles: 1 | Tokens: 8

Actors: 45 | Items: 24 | Journal Entries: 190 | Rollable Tables: 0 | Playlists: 8 | Compendium Packs: 84 | Chat Messages: 163

wake42 commented 5 months ago

I'm currently rewriting basically all the handling of rolls including this, so I'll make this part of that refactoring.

References