sun-dragon-cult / fvtt-system-rqg

Runequest Glorantha Foundry VTT system
https://sun-dragon-cult.github.io/
Other
20 stars 2 forks source link

Take into account Bonus +1 in Spirit Combat Bonus for Assistant Shaman #734

Open FranckyGtH opened 1 month ago

FranckyGtH commented 1 month ago

Hello, I propose to add this feature from Assistant Shaman :

Why: Is your feature request related to a problem?

In case of Occupation is Assistance Shaman, the bonus to Spirit combat is not into account

What: Describe the solution you'd like

I propose to update rqgCalculation.ts file.

  1. Create one additional damageBonusTable, one for AssistantShaman
  2. Update public static method : spiritCombatDamage I propose : // For Shaman Assistant - Spirit Combat Damage <= 40. Lookup with POW + CHA const assistantSpiritCombatDamageTable: LookupTableEntry[] = [ { from: -Infinity, to: 12, result: "1d3+1" }, { from: 13, to: 24, result: "1d6+1" }, { from: 25, to: 32, result: "1d6+2" }, { from: 33, to: 40, result: "1d6+4" }, ];

And update "public static spiritCombatDamage" like this : public static spiritCombatDamage(pow: number | undefined, cha: number | undefined): string { if (pow == null || cha == null) { return "0"; } const combined = pow + cha; // Add bonus +1 for Assistant Shaman if (combined <= 40) and (OccupationEnum == AssistantShaman) { return this.lookup(combined, assistantSpiritCombatDamageTable); } else { const d = Math.ceil((combined - 40) / 16); return ${d + 1}D6+${d + 3}; } if (combined <= 40) and (OccupationEnum != AssistantShaman) { return this.lookup(combined, spiritCombatDamageTable); } else { const d = Math.ceil((combined - 40) / 16); return ${d + 1}D6+${d + 2}; } }

Thank you for your great work ! Francky

The-Axel commented 1 month ago

If this is being accommodated then it should also be possible to flag a character as a Shaman so as to give the +3 bonus to Spirit Combat Damage.

Rather than applying piecemeal changes, it would probably be better to make a larger change to add all status benefits for Shaman, Rune Lord, and Rune Priest.

FranckyGtH commented 1 month ago

Except that adding all the status benefits for the shaman, rune lord and rune priest is not the same workload. These occupations don't exist, they need to be implemented in a way that has yet to be defined. And that's not a simple task, I think.

That's why I'm proposing a short change, with quick and simple modifications.

I think that 80% of those who play RQ are in the Padawan phase and not yet Jedi. So for now that should be enough.