sun-ruiheng / pe

0 stars 0 forks source link

`editm` allows adding of already existing tags #9

Open sun-ruiheng opened 6 months ago

sun-ruiheng commented 6 months ago

To replicate:

  1. Have a contact of ic S1234567D with tag diabetic
  2. editm ic/S1234567D at/diabetic

Expected: Some kind of warning that it is already an existing allergy. Actual: No warning, goes on as per normal

I think it would be good to have a sort of notice if this occurs, although functionality is not directly impacted at surface level. I can imagine perhaps at a clinic or hospital, this type of stringent warning helps prevent duplicate prescription of medication, for example.

Screenshot 2024-04-19 at 4.47.34 PM.png

nus-se-bot commented 6 months ago

Team's Response

Yes, this is indeed a problem, but I think the severity should be very low since it does affect the normal usage of the app.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: According to the definition for Low vs VeryLow, this fits Low more.

Screenshot 2024-04-23 at 2.44.50 PM.png