search

sunaku / glove80-keymaps

"Glorious Engrammer" keymap for Glove80 keyboard
https://sunaku.github.io/moergo-glove80-keyboard.html#layers
365 stars 113 forks source link

Build error when changing the default value of the DIFFICULTY_LEVEL property. #12

Closed Mathijs-Bakker closed 7 months ago

Mathijs-Bakker commented 7 months ago

Build error when changing the DIFFICULTY_LEVEL property.

When I change the DIFFICULTY_LEVEL other than 0 the build fails.

To repreduce:

Error log:

devicetree error: 
/tmp/build/build.keymap:1867 (column 49): 
parse error: expected number or parenthesized expression

Full compile log:
Loading Zephyr default modules (Zephyr base (cached)).
-- Application: /nix/store/08q7fx9jd9r1wgsxc3vjdks9f9v4lwrz-source/app
-- CMake version: 3.27.8
-- Found Python3: /nix/store/qrrwy165fvfdxcp6yn01yjbi7fsn3zmf-python3-3.11.6-env/bin/python (found suitable version "3.11.6", minimum required is "3.8") found components: Interpreter 
-- Cache files will be written to: /tmp/.cache
-- Zephyr version: 3.5.0 (/nix/store/6p8b3xwjz1w7vijrcysij2f17fn73492-zephyr/zephyr), build: 2fad527cc5abed5bb59b4d4a4b0ee511d0e514e9
-- Using keymap file: /tmp/build/build.keymap
-- Board: glove80_lh
-- Found toolchain: gnuarmemb (/nix/store/rfmw7rw1l85rvav1fymij2253w7vz070-ccache-links)
-- Found Dtc: /nix/store/vrigkjb8pzdc01ggppbfyh6mcnnv2lzw-dtc-1.7.0/bin/dtc (found suitable version "1.7.0", minimum required is "1.4.6") 
-- Found BOARD.dts: /nix/store/08q7fx9jd9r1wgsxc3vjdks9f9v4lwrz-source/app/boards/arm/glove80/glove80_lh.dts
-- Found devicetree overlay: /tmp/build/build.keymap
In file included from <command-line>:
/tmp/build/build.keymap:319: warning: "DIFFICULTY_LEVEL" redefined
  319 | #define DIFFICULTY_LEVEL 5 // expert (100ms)
      | 
/tmp/build/build.keymap:314: note: this is the location of the previous definition
  314 | #define DIFFICULTY_LEVEL 0 // custom (see defaults below)
      | 
devicetree error: /tmp/build/build.keymap:1867 (column 49): parse error: expected number or parenthesized expression

// ...
sunaku commented 7 months ago

Thank you, this is fixed now in commit bb96f54727f6f0f7cbe70c6f58143e822503984e.

Please use this updated release keymap instead (I've re-released v36 in-place):