Refactored md2man/rakefile into a Tasks class

sunaku / md2man

📚 Converts markdown into UNIX manual pages

https://sunaku.github.io/md2man/man

Other

374 stars 23 forks source link

Refactored md2man/rakefile into a Tasks class #7

Closed postmodern closed 10 years ago

postmodern commented 12 years ago

Converted the md2man/rakefile into Md2Man::Tasks:

Accepts an :options option for passing options down to Redcarpet.
Accepts a :web option for enabling/disabling generation of .html files.
Aliases the build task to md2man.

In the future more options could be added to customize the format of the .html files.

sunaku commented 12 years ago

Note that Bundler's tasks aren't stacked. That is, neither release nor install invoke build. Perhaps we should fix this upstream?

postmodern commented 12 years ago

If the additional man-pages are listed in gemspec.files but don't exist the build should fail. You are right, the build task should depend on everything in gemspec.files, so a change in a man-pages will trigger a rebuild. The install task should depend on the pkg/$name-$version.gem file as well. This is how rubygems-tasks operates.

postmodern commented 12 years ago

Submitted an issue upstream.

postmodern commented 12 years ago

On second thought, we probably shouldn't be hooking into build. Should let the developer decide how to hook md2man into their Rakefile.

sunaku commented 12 years ago

Fair enough.

sunaku commented 10 years ago

This patch adds extra steps of instantiating Md2Man::Tasks.new in the user's rakefile. That doesn't fit with my intended usage of simply requiring this library into the user's rakefile to make things work. Therefore I'm closing this pull request unmerged. Nevertheless, thanks for your patch! :bow: