sunary / sqlize

powerful SQL toolkit; offering parsing, building, and migration capabilities.
Other
97 stars 11 forks source link

Thank you very much veteran. Your review was excellent. I retranslated readme_zh.md #38

Closed liushuai05 closed 1 year ago

liushuai05 commented 1 year ago

I'm going to run sqlize_text.go I have to say your change is good, yes, it's working, and I'm ashamed that the variable names I wrote weren't standard, and the way the code was written wasn't standard. This PR is just a retranslation of readme_zh.md, I'm really sorry that my English is really poor, and the translation software may not be able to accurately express my will. I hope you understand

codecov-commenter commented 1 year ago

Codecov Report

Merging #38 (737c749) into master (36fa855) will increase coverage by 0.34%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   93.61%   93.95%   +0.34%     
==========================================
  Files           2        2              
  Lines         141      149       +8     
==========================================
+ Hits          132      140       +8     
  Misses          5        5              
  Partials        4        4              
Impacted Files Coverage Δ
options.go 100.00% <100.00%> (ø)
sqlize.go 91.58% <100.00%> (+0.32%) :arrow_up:
sunary commented 1 year ago

This is PR already merged at: https://github.com/sunary/sqlize/pull/36, please rebase your branch

liushuai05 commented 1 year ago

This is PR already merged at: #36, please rebase your branch

Ok, you mean improve-liushuai05 branch?

sunary commented 1 year ago

Sorry do not clear for you, I mean you need to rebase your branch. Could I close this, because I create the new one: https://github.com/sunary/sqlize/pull/40

liushuai05 commented 1 year ago

Sorry do not clear for you, I mean you need to rebase your branch. Could I close this, because I create the new one: #40

Of course, thank you for your patience and adjustment and optimization of my code. Maybe my experience is not enough.