Open binchensun opened 9 months ago
I am slightly confused, as I remember Sijie mentioning that he has incorporated this. And when I look at https://github.com/suncasa/suncasa-src/blob/a0db056e6d52530c869d6fb11b1f6a3d84d369c1/suncasa/utils/helioimage2fits.py#L1150C18-L1150C18 indeed, it seems that the beam position angle has been updated.. Something is odd..
Is it possible that the sign is wrong? I think it may need to be + p0 not - p0, but I could be wrong. bpatmp = qa.quantity(bpa, bpaunit)['value'] + qa.convert(qa.quantity(p0, 'deg'), bpaunit)['value']
On Wed, Dec 20, 2023 at 9:17 AM Surajit Mondal @.***> wrote:
I am slightly confused, as I remember Sijie mentioning that he has incorporated this. And when I look at https://github.com/suncasa/suncasa-src/blob/a0db056e6d52530c869d6fb11b1f6a3d84d369c1/suncasa/utils/helioimage2fits.py#L1150C18-L1150C18 https://urldefense.com/v3/__https://github.com/suncasa/suncasa-src/blob/a0db056e6d52530c869d6fb11b1f6a3d84d369c1/suncasa/utils/helioimage2fits.py*L1150C18-L1150C18__;Iw!!DLa72PTfQgg!LAfKq6LkjXaoeTM3Eoc_JNLkHcNZE0U6ZV9WsEBWfHTQBPMEEoRxmEJ5FZhw3K3FM_AYpD3QznYhUt4LF6mchjAB$ indeed, it seems that the beam position angle has been updated.. Something is odd..
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/suncasa/suncasa-src/issues/259*issuecomment-1864550512__;Iw!!DLa72PTfQgg!LAfKq6LkjXaoeTM3Eoc_JNLkHcNZE0U6ZV9WsEBWfHTQBPMEEoRxmEJ5FZhw3K3FM_AYpD3QznYhUt4LFzKyWtJI$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB5MZJQ6V2HHJSXRNQCS7NDYKLXPLAVCNFSM6AAAAABA44NR4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUGU2TANJRGI__;!!DLa72PTfQgg!LAfKq6LkjXaoeTM3Eoc_JNLkHcNZE0U6ZV9WsEBWfHTQBPMEEoRxmEJ5FZhw3K3FM_AYpD3QznYhUt4LF2FWYpu9$ . You are receiving this because you authored the thread.Message ID: @.***>
Okay, I just tested it by inverting the sign, and clearly the situation is worse...
One thing I noted is that the beam bpa is not being rotated if toTB is False. We should bring the bpa angle update outside the "if" statement..
After the images are rotated according to the solar p angle, the beam position angle is not corrected. This needs to be incorporated in helioimage2fits.py. https://github.com/suncasa/suncasa-src/blob/master/suncasa/utils/helioimage2fits.py. See below for an OVRO-LWA example.