Feature update for dspec lwa

suncasa / suncasa-src

Source code of the suncasa——CASA-based Python package for reducing, analyzing, and visualizing solar dynamic spectroscopic imaging data at radio wavelengths

BSD 2-Clause "Simplified" License

17 stars 23 forks source link

Feature update for dspec lwa #291

Closed peijin94 closed 2 months ago

peijin94 commented 2 months ago

This PR is created when creating calibrated spectrum reduced dataset of OVRO-LWA

A few features were added.

new columns added to dspec.tofits() fits, saving the cal factor list, user can apply the correction or reverse later
API to input user-defined array (or single number) correction factor list
function converting fits in RA-DEC to helio coord without info from MS

surajit4444mondal commented 2 months ago

Peijin, I took a quick look into your radec_to_helio function. I think that it would be easier if you facilitate the user with some well known observatory names instead of the EarthObserver location coordinates. So maybe you can create a dictionary with the locations of known observatories, and the name is not in the distionary, then user needs to provide the actual location in lat,long, otherwise the name is sufficient

sageyu123 commented 2 months ago

Peijin, I took a quick look into your radec_to_helio function. I think that it would be easier if you facilitate the user with some well known observatory names instead of the EarthObserver location coordinates. So maybe you can create a dictionary with the locations of known observatories, and the name is not in the distionary, then user needs to provide the actual location in lat,long, otherwise the name is sufficient

https://docs.astropy.org/en/stable/api/astropy.coordinates.EarthLocation.html#astropy.coordinates.EarthLocation.of_site to respond to @surajit4444mondal 's request, this function in EarthLocation would be useful.