search

suncat2000 / MobileDetectBundle

Symfony 2/3/4 bundle for detect mobile devices, manage mobile view and redirect to the mobile and tablet version.
397 stars 153 forks source link

Update composer.json to allow Twig v2 to be used #105

Closed netbull closed 7 years ago

grizzlylab commented 7 years ago

Thank you ! 😄

netbull commented 7 years ago

:)

suncat2000 commented 7 years ago

@netbull, @grizzlylab tagged in https://github.com/suncat2000/MobileDetectBundle/tree/v1.0.4

suncat2000 commented 7 years ago

@netbull Thanx!

xabbuh commented 7 years ago

@suncat2000 @netbull Is there actually a reason you are implementing the \Twig_Extension_GlobalsInterface?

netbull commented 7 years ago

@suncat2000 the bundle deserves maintenance

@xabbuh is did't implemented this interface. In Twig v1 is actually empty interface who know why it was there, but in v2 is with getGlobals function... again who knows why is there. I think is not necessary to implement it at all.

suncat2000 commented 7 years ago

@xabbuh I am not remember now, but this interface I added when implement sf3.0 support. I recheck now and remove if it is possible.

netbull commented 7 years ago

@suncat2000 I think it's not needed

suncat2000 commented 7 years ago

@xabbuh, @netbull removed in https://github.com/suncat2000/MobileDetectBundle/tree/v1.0.5. Thanks guys!

xabbuh commented 7 years ago

Thanks for the fast reaction @suncat2000!