[WIP] Refactor and upgrade services definition to remove deprecated notices

suncat2000 / MobileDetectBundle

Symfony 2/3/4 bundle for detect mobile devices, manage mobile view and redirect to the mobile and tablet version.

397 stars 153 forks source link

Closed fdespier closed 7 years ago

fdespier commented 7 years ago

Hi all,

Update composer to use Symfony 3.3
Upgrade Service definition
- XML files are deprecated in SF 3.4 (and remove in 4.0)
- Use Classname instead alias
- use autowire when it's possible
- Remove class parameters (unused method since SF 2.7)
Upgrade autoload to PSR-4 (PSR-0 is deprecated)
Fix checkstyle with Symfony2 rules
Twig extension : getName method is now deprecated

best,

xabbuh commented 7 years ago

Using XML files to configure your services is not deprecated and will still work in Symfony 4.

fdespier commented 7 years ago

@xabbuh My bad, an issue was open on this topic and you're right (https://github.com/symfony/symfony/issues/22870) .

XML format is'nt deprecated but not the mainstream method to define services.

fdespier commented 7 years ago

Hi all,

I think, it will be better to refactor the service declaration of this bundle in an other branch (2.X) to prevent BC break.

@suncat2000 could you answer to my issue #115 ?

best,