Symfony 3.3 deprecated service declaration

suncat2000 / MobileDetectBundle

Symfony 2/3/4 bundle for detect mobile devices, manage mobile view and redirect to the mobile and tablet version.

397 stars 153 forks source link

Symfony 3.3 deprecated service declaration #115

Open fdespier opened 7 years ago

fdespier commented 7 years ago

Hi @suncat2000,

Autowiring services based on the types they implement is deprecated since Symfony 3.3 and won't be supported in version 4.0.You should rename (or alias) the "mobile_detect.device_view" service to "SunCat\MobileDetectBundle\Helper\DeviceView" instead.

What do you think to make a new branch 2.X to handle new version of Symfony (>3.4) ?

20uf commented 7 years ago

:+1:

xabbuh commented 7 years ago

Do you really want to maintain two branches just to avoid some if conditions inside the DI extension class? I don't think that's worth it.