fix tests - Githubissues

suncat2000 / MobileDetectBundle

Symfony 2/3/4 bundle for detect mobile devices, manage mobile view and redirect to the mobile and tablet version.

397 stars 153 forks source link

Closed xabbuh closed 6 years ago

xabbuh commented 6 years ago

use createMock() instead of getMock() (which is deprecated)
allow more compatible PHPUnit versions
use the installed PHPUnit version instead of the global one shipped with Travis CI
extend from the namespaced TestCase class (the PEAR-style like class is not available in PHPUnit 6)

bocharsky-bw commented 6 years ago

Hey @suncat2000 , can we merge it soon?

suncat2000 commented 6 years ago

@bocharsky-bw sorry, I was unavailable((

bocharsky-bw commented 6 years ago

@suncat2000 No problem, glad we got it merged!

Can we also merge #121 ? I rebased it on this PR and fixed tests - now tests are truly green :)

nckenn commented 6 years ago

@suncat2000 make a release version :)

suncat2000 commented 6 years ago

@nckenn @bocharsky-bw fixed v1.1.0