Fix/symfony 4 support - Githubissues

suncat2000 / MobileDetectBundle

Symfony 2/3/4 bundle for detect mobile devices, manage mobile view and redirect to the mobile and tablet version.

397 stars 153 forks source link

Fix/symfony 4 support #127

Closed alexhoma closed 6 years ago

alexhoma commented 6 years ago

Added compatibility to Symfony4. There are other Pull Requests about this issue but none is passing the Travis tests and/or it seems there is no progress on the issue. Since we need this library to work on Symfony4 I'm making my own PR.

Updates:

Updated bundle dependencies
Change the way the device.html.twig is called on the listener.xml
Readme/composer.json update adding support for Symfony4

xabbuh commented 6 years ago

this looks like a duplicate of #123

alexhoma commented 6 years ago

Hi @xabbuh, I know. But it seems nobody has been listening since Jan 16 https://github.com/suncat2000/MobileDetectBundle/pull/123#issuecomment-357945433 So I decided to start a new PR with the passing tests to see if we can fix this.

abarke commented 6 years ago

Could someone pls merge this. Would be great :)