search

suncat2000 / MobileDetectBundle

Symfony 2/3/4 bundle for detect mobile devices, manage mobile view and redirect to the mobile and tablet version.
397 stars 153 forks source link

Why not handle ESI? #36

Open borisguery opened 10 years ago

borisguery commented 10 years ago

Having experienced an issue with an ESI request, I took a quick look at the code and I realized that the listener ignores sub-requests (used by ESI).

There: https://github.com/suncat2000/MobileDetectBundle/commit/444e595d1eb0b2f8d83f395100c8db7e2cc868cf#diff-1ef8ac159e28a851a5ada1b954455703R72

I'm wondering why? It looks inconsistent to me because I would expect to be allowed to use issers methods in the same way to render a consistent views/layouts.

ricoli commented 10 years ago

Probably because the most common case is that people want to ignore ESI... It could be configurable though - try submitting a PR for it if you still need it :)