search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Deploy documentation to github pages #110

Closed sunchao closed 6 years ago

sunchao commented 6 years ago

Followed the steps you provided @sadikovi . Can you review this? Thanks!

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 94.851% when pulling 4163cc6b9d417689cf168f22baeef834bef954fc on deploy-docs into 5143db1835fd04cea659bf6fe0c814eb35efc2a8 on master.

sadikovi commented 6 years ago

Would love to get this merged, so we can close release 0.2.0.

Are we going to release 0.3.0 right after this PR is merged? That would be great, IMHO.

sunchao commented 6 years ago

Thanks @sadikovi . Let me merge this first to see if it works.

Have you considered adding badges for documentation or update existing links?

Will add once this works.

sadikovi commented 6 years ago

Cheers. You might need to retag 0.2.0 or create a new tag, so it has the latest changes. Can’t wait to see docs!

sunchao commented 6 years ago

Are we going to release 0.3.0 right after this PR is merged? That would be great, IMHO.

Hmm I haven't thought about it. Is that because we want to have the doc cover the latest changes? we can do a 0.2.1 release maybe?

sadikovi commented 6 years ago

Nah, I was just thinking there were a lot of changes already for 0.3.0. But I am happy either way!

sunchao commented 6 years ago

Cool. I just added a badge for the master branch doc. For some reason, the doc for 0.2.0 didn't show up. Do you have any idea?

sadikovi commented 6 years ago

It uses old Travis file. You would need to run it on the latest changes. I think that’s why.

sunchao commented 6 years ago

OK I see. So we need to have a new release and then trigger the travis job again. right?

BTW the docs looks really nice. 👍 Thanks @sadikovi for all the work you've done!

sadikovi commented 6 years ago

Probably. It is worth a try.

All good. Happy to help. On Fri, 4 May 2018 at 6:22 PM, Chao Sun notifications@github.com wrote:

OK I see. So we need to have a new release and then trigger the travis job again. right?

BTW the docs looks really nice. 👍 Thanks @sadikovi https://github.com/sadikovi for all the work you've done!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sunchao/parquet-rs/pull/110#issuecomment-386514581, or mute the thread https://github.com/notifications/unsubscribe-auth/AHbY3sUd93H2cL5F9l46z5urbeyz6Mukks5tu_OegaJpZM4Twl8J .