Replace x86intrin with stable SIMD

sunchao / parquet-rs

Apache Parquet implementation in Rust

Apache License 2.0

149 stars 20 forks source link

Replace x86intrin with stable SIMD #118

Closed sunchao closed 6 years ago

sunchao commented 6 years ago

Currently the SIMD feature requires the x86intrin crate and a compile time flag RUSTFLAGS="-C target-feature=+sse4.2", which is not convenient. This replaces the x86intrin dependency with recently stablized SIMD features, and also replaces the cfg(target_feature) flag with is_x86_feature_detected, which dynamically determines whether SSE 4.2 is supported or not.

Fixes #113.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 507

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 94.927%

Files with Coverage Reduction	New Missed Lines	%
util/hash_util.rs	1	98.63%
<!--	Total:	1		-->

Totals
Change from base Build 505:	0.02%
Covered Lines:	10180
Relevant Lines:	10724

💛 - Coveralls

sunchao commented 6 years ago

Merged. Thanks @sadikovi .