Closed sadikovi closed 6 years ago
I am slowly working on write path, and this is one of the helper PRs with relatively small changes.
Interestingly cargo doc --no-deps
generates lots of warnings, and cargo coveralls
is failing again (which I think is expected since our travis cargo is not set up properly).
Merged. Thanks @sadikovi !
@sunchao Thanks!
This PR adds conversion from
parquet::XYZ
toXYZ
. This is needed when writing the enums into as part of parquet format structs. This allows to do the following:Basically implements
From<XYZ> for parquet::XYZ
for physical type, logical type, page type, compression, encoding, and repetition. I did not add column order, because it needs to be converted differently, since there is no direct one-to-one mapping with format definition.Added unit tests, and made some small changes, like
tp
intovalue
to be consistent in methods for non-type enum names, likeEncoding
orCompression
.