search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Fix travis code coverage #124

Closed sunchao closed 6 years ago

sunchao commented 6 years ago

The installation steps for cargo-travis were deleted by mistake. The CI jobs were succeeding because it was using cache, but recently started to fail because the cache is gone. This fixes it.

sadikovi commented 6 years ago

Well done! I actually did not notice it:) Thanks for fixing the issue.

sunchao commented 6 years ago

NP. Seems it is still failing for that types.h not found error. Looking...

sadikovi commented 6 years ago

I was thinking if it could be related to using travis-cargo test command instead of cargo test, but it could be something else indeed (looks like that is the only thing that is different between the two conf files).

sunchao commented 6 years ago

Yeah the error was strange - seems it is trying to compile against x86 but the docker environment was set up for x86_64.

sunchao commented 6 years ago

The failure was caused by https://github.com/SimonKagstrom/kcov/issues/262, and the original commit that caused the issue was reverted. Coveralls worked in the latest build.

sadikovi commented 6 years ago

Thanks. Well done!