sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Add WriterProperties to configure file writer #128

Closed sadikovi closed 6 years ago

sadikovi commented 6 years ago

This PR adds writer properties that allow to configure file writer and column writers.

User can create easily create properties with default values, or specify different configuration either globally or for an individual column.

I also added build.rs (again!). This is used to generate created_by string that includes current version and the latest git commit hash.

Notes:

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 541


Totals Coverage Status
Change from base Build 533: -0.07%
Covered Lines: 10735
Relevant Lines: 11279

💛 - Coveralls
sadikovi commented 6 years ago

@sunchao could you review this PR? Let me know if I need to write more tests, also to increase coverage. Thanks!

sadikovi commented 6 years ago

Thanks @sunchao! I hope this will work:).

sadikovi commented 6 years ago

@sunchao Feel free to leave more comments - I am more than happy to address them, so we can make parquet-rs the best and the fastest Parquet implementation.

sunchao commented 6 years ago

@sadikovi Thanks. This looks good to me 👍 . Will merge now.